Skip to content

chore: Omnichannel QoL improvements #34865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 2 commits into from
Jan 21, 2025
Merged

chore: Omnichannel QoL improvements #34865

kodiakhq merged 2 commits into from
Jan 21, 2025

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Jan 2, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

This does 4 things:

  • Restore the autoCloseQueued hook, in charge of removing the agenda jobs of queued rooms after they're taken. No noticeable side effect, as the query that runs looks for queued items, so the only issue was that it was running more than it should.
  • Removes the update on subscriptions after a room is closed. We remove the subs of the room when we close it, so this update was a no-op db call
  • Makes the autocloseonhold to only run (when a room is closed) if the auto close timeout has a truthy value (> 0)
  • Converts 2 promises in a promise.all

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 2, 2025 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2ebed71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KevLehman KevLehman changed the title minor stuff chore: Omni small code changes Jan 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34865/

Built to branch gh-pages at 2025-01-21 13:49 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jan 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.13%. Comparing base (a5b4584) to head (2ebed71).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34865      +/-   ##
===========================================
- Coverage    59.17%   59.13%   -0.05%     
===========================================
  Files         2822     2820       -2     
  Lines        68124    67795     -329     
  Branches     15149    15069      -80     
===========================================
- Hits         40314    40089     -225     
+ Misses       24978    24894      -84     
+ Partials      2832     2812      -20
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review January 21, 2025 13:45
@KevLehman KevLehman requested a review from a team as a code owner January 21, 2025 13:45
@KevLehman KevLehman changed the title chore: Omni small code changes chore: Omnichannel QoL improvements Jan 21, 2025
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Jan 21, 2025
@MarcosSpessatto MarcosSpessatto added this to the 7.4.0 milestone Jan 21, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 21, 2025
@kodiakhq kodiakhq bot merged commit 5261f03 into develop Jan 21, 2025
52 checks passed
@kodiakhq kodiakhq bot deleted the chore/code-up branch January 21, 2025 17:38
juliajforesti pushed a commit that referenced this pull request Jan 28, 2025
@KevLehman @juliajforesti
chore: Omnichannel QoL improvements (#34865)
7733ef4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

+1 more reviewer

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@KevLehman @MarcosSpessatto @MartinSchoeler @ggazzo